Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10420] Removed PinpointNettyServerBuilder, Tracing gRPC logId #10428

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Oct 22, 2023

No description provided.

@smilu97 smilu97 self-assigned this Oct 22, 2023
@smilu97 smilu97 force-pushed the 10420_deprecate_pinpoint_netty_server_builder branch from 6e7cd47 to ded5cfe Compare October 22, 2023 08:07
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (0601f71) 38.21% compared to head (cc20e5a) 38.23%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10428      +/-   ##
============================================
+ Coverage     38.21%   38.23%   +0.02%     
+ Complexity    11769    11759      -10     
============================================
  Files          3725     3724       -1     
  Lines         93677    93491     -186     
  Branches      10229    10219      -10     
============================================
- Hits          35796    35750      -46     
+ Misses        54872    54744     -128     
+ Partials       3009     2997      -12     
Files Coverage Δ
...rp/pinpoint/collector/service/ChannelzService.java 100.00% <100.00%> (ø)
...pinpoint/grpc/server/DefaultTransportMetadata.java 58.33% <100.00%> (+1.19%) ⬆️
...int/grpc/server/MetadataServerTransportFilter.java 55.55% <ø> (-2.34%) ⬇️
.../navercorp/pinpoint/grpc/server/ServerFactory.java 83.33% <90.90%> (+0.45%) ⬆️
...pinpoint/grpc/server/TransportMetadataFactory.java 64.28% <50.00%> (+14.28%) ⬆️
...eceiver/grpc/channelz/DefaultChannelzRegistry.java 71.42% <60.00%> (+8.46%) ⬆️
grpc/src/main/java/io/grpc/netty/NettyUtils.java 0.00% <0.00%> (ø)
...avercorp/pinpoint/grpc/channelz/ChannelzUtils.java 0.00% <0.00%> (ø)
...npoint/collector/service/ChannelzSocketLookup.java 61.11% <61.11%> (ø)
...ollector/service/InternalChannelzSocketLookup.java 71.42% <71.42%> (ø)
... and 2 more

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smilu97 smilu97 force-pushed the 10420_deprecate_pinpoint_netty_server_builder branch 5 times, most recently from e0d9732 to fe583cc Compare October 24, 2023 02:39
@smilu97 smilu97 force-pushed the 10420_deprecate_pinpoint_netty_server_builder branch from 78ae66e to cc20e5a Compare October 24, 2023 06:02
@smilu97 smilu97 merged commit 957f1ba into pinpoint-apm:master Oct 24, 2023
3 checks passed
@smilu97 smilu97 deleted the 10420_deprecate_pinpoint_netty_server_builder branch October 24, 2023 06:27
@smilu97 smilu97 linked an issue Oct 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate PinpointNettyServerBuilder
1 participant