Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10534] Update vertx plugin to support vert.x 4.5.0 version #10535

Merged

Conversation

jaehong-kim
Copy link
Contributor

@jaehong-kim jaehong-kim added this to the 3.0.0 milestone Dec 1, 2023
@jaehong-kim jaehong-kim self-assigned this Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (425096a) 37.66% compared to head (6a0c1ee) 37.63%.
Report is 3 commits behind head on master.

Files Patch % Lines
...m/navercorp/pinpoint/plugin/vertx/VertxPlugin.java 0.00% 26 Missing ⚠️
...ceptor/HttpClientImplCreateRequestInterceptor.java 0.00% 13 Missing ⚠️
...erceptor/HttpClientImplDoRequestInterceptorV4.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10535      +/-   ##
============================================
- Coverage     37.66%   37.63%   -0.03%     
- Complexity    11721    11722       +1     
============================================
  Files          3747     3748       +1     
  Lines         94092    94142      +50     
  Branches      10247    10256       +9     
============================================
- Hits          35438    35432       -6     
- Misses        55703    55760      +57     
+ Partials       2951     2950       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaehong-kim jaehong-kim merged commit 3896d4c into pinpoint-apm:master Dec 4, 2023
1 of 3 checks passed
@jaehong-kim jaehong-kim deleted the update-vertx-plugin-support-4 branch December 4, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant