Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#noissue] Capture context when throwing SpanInsertEvent #10584

Merged
merged 1 commit into from
Dec 28, 2023
Merged

[#noissue] Capture context when throwing SpanInsertEvent #10584

merged 1 commit into from
Dec 28, 2023

Conversation

kojandy
Copy link
Contributor

@kojandy kojandy commented Dec 28, 2023

No description provided.

@kojandy kojandy self-assigned this Dec 28, 2023
@kojandy kojandy marked this pull request as ready for review December 28, 2023 01:54
@kojandy kojandy requested a review from emeroad December 28, 2023 01:54
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8c0a043) 38.16% compared to head (5fcf76f) 38.14%.
Report is 9 commits behind head on master.

Files Patch % Lines
...npoint/collector/event/SpanStorePublisherImpl.java 0.00% 5 Missing ⚠️
.../pinpoint/collector/service/HbaseTraceService.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #10584      +/-   ##
============================================
- Coverage     38.16%   38.14%   -0.02%     
+ Complexity    11919    11914       -5     
============================================
  Files          3770     3771       +1     
  Lines         94508    94530      +22     
  Branches      10285    10287       +2     
============================================
- Hits          36067    36062       -5     
- Misses        55449    55472      +23     
- Partials       2992     2996       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

emeroad
emeroad approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@emeroad emeroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kojandy kojandy merged commit b8c0de5 into pinpoint-apm:master Dec 28, 2023
1 of 3 checks passed
@kojandy kojandy deleted the fix/threadlocal-async branch December 28, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emeroad emeroad emeroad approved these changes

Assignees

@kojandy kojandy

Labels
module:collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kojandy @emeroad