Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10604] Mark multiple sql executions as error #10596

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

kojandy
Copy link
Contributor

@kojandy kojandy commented Jan 8, 2024

Resolves #10604.

@kojandy kojandy self-assigned this Jan 8, 2024
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (707e74c) 38.11% compared to head (2f1f289) 38.12%.
Report is 4 commits behind head on master.

❗ Current head 2f1f289 differs from pull request most recent head 0f54805. Consider uploading reports for the commit 0f54805 to get more accurate results

Files Patch % Lines
...ler/context/recorder/WrappedSpanEventRecorder.java 30.00% 7 Missing ⚠️
...point/profiler/context/DefaultSqlCountService.java 75.00% 1 Missing and 2 partials ⚠️
...point/profiler/context/DisableSqlCountService.java 0.00% 2 Missing ⚠️
...iler/context/provider/SqlCountServiceProvider.java 66.66% 1 Missing and 1 partial ⚠️
...nterceptor/PreparedStatementCreateInterceptor.java 0.00% 1 Missing ⚠️
...ptor/PreparedStatementExecuteQueryInterceptor.java 0.00% 1 Missing ⚠️
...or/InformixPreparedStatementCreateInterceptor.java 0.00% 1 Missing ⚠️
...r2dbc/interceptor/StatementExecuteInterceptor.java 0.00% 1 Missing ⚠️
...ceptor/mssql/MssqlStatementExecuteInterceptor.java 0.00% 1 Missing ⚠️
.../context/recorder/ChildTraceSpanEventRecorder.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #10596   +/-   ##
=========================================
  Coverage     38.11%   38.12%           
- Complexity    11919    11925    +6     
=========================================
  Files          3777     3782    +5     
  Lines         94604    94622   +18     
  Branches      10306    10311    +5     
=========================================
+ Hits          36055    36070   +15     
+ Misses        55559    55558    -1     
- Partials       2990     2994    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kojandy kojandy marked this pull request as ready for review January 9, 2024 06:09
@kojandy kojandy requested a review from emeroad January 9, 2024 06:09
@kojandy kojandy changed the title [#noissue] Mark multiple sql executions as error [#10604] Mark multiple sql executions as error Jan 11, 2024
@kojandy kojandy force-pushed the feature/sql-count branch 2 times, most recently from 789d000 to 2faef10 Compare January 15, 2024 05:30
@emeroad emeroad merged commit 447e328 into pinpoint-apm:master Jan 15, 2024
1 check passed
@kojandy kojandy deleted the feature/sql-count branch January 15, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark multiple sql execution within single transaction as error
2 participants