Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Replace Node and Link states with JsonView #10598

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jan 9, 2024

No description provided.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (707e74c) 38.11% compared to head (251d174) 38.10%.
Report is 1 commits behind head on master.

Files Patch % Lines
...t/web/applicationmap/controller/MapController.java 0.00% 34 Missing ⚠️
...va/com/navercorp/pinpoint/web/vo/SearchOption.java 0.00% 15 Missing ⚠️
...int/web/applicationmap/service/MapServiceImpl.java 0.00% 11 Missing ⚠️
...om/navercorp/pinpoint/web/view/NodeSerializer.java 0.00% 11 Missing ⚠️
...p/pinpoint/web/applicationmap/nodes/NodeViews.java 0.00% 7 Missing ⚠️
...t/web/applicationmap/service/MapServiceOption.java 0.00% 7 Missing ⚠️
...plicationmap/controller/FilteredMapController.java 0.00% 4 Missing ⚠️
...point/web/applicationmap/link/LinkListFactory.java 71.42% 2 Missing ⚠️
...rp/pinpoint/web/applicationmap/link/LinkViews.java 71.42% 1 Missing and 1 partial ⚠️
...corp/pinpoint/web/applicationmap/map/MapViews.java 33.33% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10598      +/-   ##
============================================
- Coverage     38.11%   38.10%   -0.02%     
+ Complexity    11919    11914       -5     
============================================
  Files          3777     3779       +2     
  Lines         94604    94592      -12     
  Branches      10306    10307       +1     
============================================
- Hits          36055    36040      -15     
- Misses        55559    55561       +2     
- Partials       2990     2991       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad changed the title [#noissue] Cleanup ServerMap [#noissue] Replace Node and Link states with JsonView Jan 9, 2024
@emeroad emeroad force-pushed the #noissue_cleanupmap branch 2 times, most recently from 488cb1c to 7a0112b Compare January 10, 2024 07:33
@emeroad emeroad merged commit b5b9ade into pinpoint-apm:master Jan 12, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant