Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10615] Add new Main classes to SpringBootDetector #10616

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

nooose
Copy link
Contributor

@nooose nooose commented Jan 16, 2024

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (447e328) 38.11% compared to head (fcd8113) 38.11%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10616      +/-   ##
============================================
- Coverage     38.11%   38.11%   -0.01%     
+ Complexity    11925    11924       -1     
============================================
  Files          3782     3782              
  Lines         94622    94624       +2     
  Branches      10311    10311              
============================================
- Hits          36069    36067       -2     
- Misses        55559    55562       +3     
- Partials       2994     2995       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donghun-cho donghun-cho self-requested a review January 17, 2024 11:30
@donghun-cho donghun-cho added this to the 3.0.0 milestone Jan 17, 2024
@donghun-cho donghun-cho linked an issue Jan 17, 2024 that may be closed by this pull request
@donghun-cho
Copy link
Contributor

Thanks for the contribution.
One last thing before merge, let's squash the commits into a single.
Could you please squash the commits and force-push?

Copy link
Contributor

@donghun-cho donghun-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please squash the commits and force-push?

@nooose nooose force-pushed the feature/springboot-detector branch from e54f9bd to fcd8113 Compare January 17, 2024 12:57
@nooose
Copy link
Contributor Author

nooose commented Jan 17, 2024

I'm done.
Thank you for contribution guiding

@donghun-cho donghun-cho merged commit aadaeb8 into pinpoint-apm:master Jan 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to detect applicationtype in the Spring Boot 3.2.X
3 participants