Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9631] Integrate ExceptionContext lifecycle into ExceptionRecordingService #10619

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jan 17, 2024

…ervice

@emeroad emeroad added this to the 3.0.0 milestone Jan 17, 2024
@emeroad emeroad requested a review from intr3p1d January 17, 2024 02:47
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (ef2d01b) 37.82% compared to head (53482a3) 37.83%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ption/DefaultExceptionRecordingServiceFactory.java 0.00% 8 Missing ⚠️
...xt/exception/DefaultExceptionRecordingService.java 50.00% 4 Missing ⚠️
...avercorp/pinpoint/profiler/context/ChildTrace.java 0.00% 2 Missing ⚠️
...oint/profiler/context/DefaultBaseTraceFactory.java 33.33% 2 Missing ⚠️
.../profiler/context/module/ExceptionTraceModule.java 0.00% 2 Missing ⚠️
...tion/ExceptionRecordingServiceFactoryProvider.java 0.00% 2 Missing ⚠️
...filer/context/recorder/DefaultRecorderFactory.java 60.00% 2 Missing ⚠️
...p/pinpoint/profiler/context/AsyncDefaultTrace.java 0.00% 1 Missing ⚠️
...ercorp/pinpoint/profiler/context/DefaultTrace.java 66.66% 1 Missing ⚠️
...on/disabled/DisabledExceptionRecordingService.java 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #10619   +/-   ##
=========================================
  Coverage     37.82%   37.83%           
- Complexity    11865    11870    +5     
=========================================
  Files          3791     3793    +2     
  Lines         94115    94130   +15     
  Branches      10219    10220    +1     
=========================================
+ Hits          35602    35610    +8     
- Misses        55572    55581    +9     
+ Partials       2941     2939    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

import com.navercorp.pinpoint.profiler.context.exception.disabled.DisabledExceptionRecordingService;
import com.navercorp.pinpoint.profiler.context.id.TraceRoot;

public class DisableExceptionRecordingServiceFactory implements ExceptionRecordingServiceFactory {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a typo: DisableExceptionRecordingServiceFactory -> DisabledExceptionRecordingServiceFactory

ref)
DisabledExceptionRecordingService
DisabledExceptionRecordingServiceFactoryProvider

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

@intr3p1d
Copy link
Contributor

LGTM 👍

@emeroad emeroad merged commit 91074a4 into pinpoint-apm:master Jan 25, 2024
3 checks passed
@emeroad emeroad deleted the #9631_exceptionContext branch January 25, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants