-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#9631] Integrate ExceptionContext lifecycle into ExceptionRecordingService #10619
Conversation
5fdd297
to
de7b5a0
Compare
import com.navercorp.pinpoint.profiler.context.exception.disabled.DisabledExceptionRecordingService; | ||
import com.navercorp.pinpoint.profiler.context.id.TraceRoot; | ||
|
||
public class DisableExceptionRecordingServiceFactory implements ExceptionRecordingServiceFactory { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a typo: DisableExceptionRecordingServiceFactory -> DisabledExceptionRecordingServiceFactory
ref)
DisabledExceptionRecordingService
DisabledExceptionRecordingServiceFactoryProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it.
LGTM 👍 |
…onRecordingService
de7b5a0
to
53482a3
Compare
…ervice