Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10605] Added cleanup inactive applications batch job #10646

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Jan 24, 2024

resolves #10605

The conditions to clean an application is below

  1. Any span about this application does not exist in hbase
  2. Any agent is not alive currently

Checking the condition 2 (agent aliveness) might be unstable because of the TCP connection, but I think it would be supplemented by the condition 1. Also cleaning application does not mean to clean other informations like span or metadata of agent

@smilu97 smilu97 self-assigned this Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 99 lines in your changes are missing coverage. Please review.

Comparison is base (91074a4) 37.85% compared to head (c8bf184) 37.80%.

Files Patch % Lines
...avercorp/pinpoint/batch/job/ApplicationReader.java 0.00% 26 Missing ⚠️
...corp/pinpoint/batch/common/StartupJobLauncher.java 0.00% 20 Missing ⚠️
...pinpoint/batch/service/ApplicationServiceImpl.java 0.00% 19 Missing ⚠️
...orp/pinpoint/batch/job/ApplicationEmptyFilter.java 0.00% 11 Missing ⚠️
...vercorp/pinpoint/batch/job/ApplicationRemover.java 0.00% 10 Missing ⚠️
...ercorp/pinpoint/batch/common/BatchJobLauncher.java 0.00% 4 Missing ⚠️
.../navercorp/pinpoint/batch/job/EmptyItemWriter.java 0.00% 4 Missing ⚠️
...vercorp/pinpoint/batch/common/BatchProperties.java 0.00% 2 Missing ⚠️
...java/com/navercorp/pinpoint/batch/BatchModule.java 0.00% 1 Missing ⚠️
...guration/CleanupInactiveApplicationsJobConfig.java 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10646      +/-   ##
============================================
- Coverage     37.85%   37.80%   -0.05%     
  Complexity    11881    11881              
============================================
  Files          3795     3802       +7     
  Lines         94177    94275      +98     
  Branches      10228    10232       +4     
============================================
- Hits          35646    35643       -3     
- Misses        55588    55689     +101     
  Partials       2943     2943              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smilu97 smilu97 force-pushed the 10605_applications branch 3 times, most recently from 307c6dd to 115571c Compare January 26, 2024 05:37
@smilu97 smilu97 merged commit 31e3616 into pinpoint-apm:master Jan 26, 2024
1 of 3 checks passed
@smilu97 smilu97 deleted the 10605_applications branch January 26, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup on application name tab.
1 participant