Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10605] Deprecated cleanupInactiveAgentsJob #10654

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Jan 30, 2024

resolves #10605

@smilu97 smilu97 self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 124 lines in your changes are missing coverage. Please review.

Comparison is base (8a48d6b) 37.76% compared to head (52eebdf) 37.70%.
Report is 1 commits behind head on master.

Files Patch % Lines
...npoint/batch/job/ApplicationCleaningProcessor.java 0.00% 26 Missing ⚠️
...avercorp/pinpoint/batch/job/CleanTargetWriter.java 0.00% 17 Missing ⚠️
...m/navercorp/pinpoint/batch/job/ItemListWriter.java 0.00% 16 Missing ⚠️
...t/web/dao/hbase/HbaseApplicationTraceIndexDao.java 22.22% 12 Missing and 2 partials ⚠️
...com/navercorp/pinpoint/batch/job/AgentRemover.java 0.00% 10 Missing ⚠️
...avercorp/pinpoint/batch/job/ApplicationReader.java 0.00% 10 Missing ⚠️
.../pinpoint/batch/service/BatchAgentServiceImpl.java 0.00% 8 Missing ⚠️
...a/com/navercorp/pinpoint/batch/vo/CleanTarget.java 0.00% 7 Missing ⚠️
...orp/pinpoint/web/service/AgentInfoServiceImpl.java 0.00% 6 Missing ⚠️
...vercorp/pinpoint/web/service/AdminServiceImpl.java 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10654      +/-   ##
============================================
- Coverage     37.76%   37.70%   -0.07%     
+ Complexity    11878    11872       -6     
============================================
  Files          3803     3808       +5     
  Lines         94373    94450      +77     
  Branches      10244    10253       +9     
============================================
- Hits          35640    35611      -29     
- Misses        55788    55896     +108     
+ Partials       2945     2943       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smilu97 smilu97 merged commit 591a7c5 into pinpoint-apm:master Jan 31, 2024
1 of 3 checks passed
@smilu97 smilu97 deleted the 10605_deprecate_clean_agent branch January 31, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup on application name tab.
1 participant