Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Fix kotlin-coroutines-it assertMethod #10677

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import kotlinx.coroutines.CoroutineDispatcher;
import kotlinx.coroutines.Dispatchers;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Assumptions;
import org.junit.jupiter.api.Test;

import java.util.Arrays;
Expand Down Expand Up @@ -86,8 +85,6 @@ public void executeRunBlockingWitoutContext() {
assertResumeWith(executedMethod, index, activeAsync);
// println("Hello World 2") // job2
assertResumeWith(executedMethod, index, activeAsync);
// println("Hello all of jobs") // rootjob
assertResumeWith(executedMethod, index, activeAsync);
}

@Test
Expand All @@ -103,7 +100,7 @@ public void executeRunBlocking() {
verifier.awaitTraceCount(17, 10L, 1000L);

List<String> executedMethod = verifier.getExecutedMethod();
Assumptions.assumeTrue(executedMethod.size() == 17);
// Assumptions.assumeTrue(executedMethod.size() == 17);

AtomicInteger index = new AtomicInteger(0);

Expand All @@ -120,17 +117,6 @@ public void executeRunBlocking() {

// println("Hello all of jobs") // rootjob
assertResumeWith(executedMethod, index, activeAsync);

// delay(10L) // job1
assertResumeWithAndSchedule(executedMethod, index, activeAsync);

// delay(5L) // job2
assertResumeWithAndSchedule(executedMethod, index, activeAsync);

// println("Hello World 1") // job1
assertResumeWith(executedMethod, index, activeAsync);
// println("Hello World 2") // job2
assertResumeWith(executedMethod, index, activeAsync);
} catch (Throwable th) {
System.out.println("methods:");
for (final String method: executedMethod) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
import kotlinx.coroutines.CoroutineDispatcher;
import kotlinx.coroutines.Dispatchers;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Assumptions;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import java.util.Arrays;
Expand Down Expand Up @@ -87,11 +85,8 @@ public void executeRunBlockingWitoutContext() {
assertResumeWith(executedMethod, index, activeAsync);
// println("Hello World 2") // job2
assertResumeWith(executedMethod, index, activeAsync);
// println("Hello all of jobs") // rootjob
assertResumeWith(executedMethod, index, activeAsync);
}

@Disabled
@Test
public void executeRunBlocking() {
final boolean activeAsync = true;
Expand All @@ -105,7 +100,6 @@ public void executeRunBlocking() {
verifier.awaitTraceCount(17, 10L, 1000L);

List<String> executedMethod = verifier.getExecutedMethod();
Assumptions.assumeTrue(executedMethod.size() == 17);

AtomicInteger index = new AtomicInteger(0);

Expand All @@ -123,17 +117,6 @@ public void executeRunBlocking() {
// println("Hello all of jobs") // rootjob
assertResumeWith(executedMethod, index, activeAsync);

// delay(10L) // job1
assertResumeWithAndSchedule(executedMethod, index, activeAsync);

// delay(5L) // job2
assertResumeWithAndSchedule(executedMethod, index, activeAsync);

// println("Hello World 1") // job1
assertResumeWith(executedMethod, index, activeAsync);

// println("Hello World 2") // job2
assertResumeWith(executedMethod, index, activeAsync);
} catch (Throwable th) {
System.out.println("methods:");
for (final String method: executedMethod) {
Expand Down
Loading