Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10723] Improved large scanner to read in chunks #10744

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Mar 12, 2024

No description provided.

@emeroad emeroad added this to the 3.0.0 milestone Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 32.14286% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 37.60%. Comparing base (d8a7968) to head (a906691).

Files Patch % Lines
...npoint/common/hbase/scan/ResultScannerFactory.java 16.66% 24 Missing and 1 partial ⚠️
...ommon/hbase/scan/DefaultResultScannerSupplier.java 0.00% 17 Missing ⚠️
...navercorp/pinpoint/common/hbase/HbaseTemplate.java 0.00% 7 Missing ⚠️
...orp/pinpoint/common/hbase/scan/DefaultScanner.java 84.61% 4 Missing ⚠️
...t/common/hbase/util/DefaultScanMetricReporter.java 0.00% 3 Missing ⚠️
...int/common/hbase/util/EmptyScanMetricReporter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10744      +/-   ##
============================================
+ Coverage     37.58%   37.60%   +0.01%     
- Complexity    11956    11970      +14     
============================================
  Files          3847     3850       +3     
  Lines         95382    95449      +67     
  Branches      10332    10339       +7     
============================================
+ Hits          35854    35897      +43     
- Misses        56578    56601      +23     
- Partials       2950     2951       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad linked an issue Mar 12, 2024 that may be closed by this pull request
@emeroad emeroad merged commit 9c2de10 into pinpoint-apm:master Mar 12, 2024
2 of 3 checks passed
@emeroad emeroad deleted the #10723_scanmetric branch March 13, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ScanMetrics for Scan Performance Measurements
1 participant