Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#noissue] Cleanup #10843

Merged
merged 1 commit into from
Apr 4, 2024
Merged

[#noissue] Cleanup #10843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
@Repository
public class PinotExceptionTraceDao implements ExceptionTraceDao {
private final Logger logger = LogManager.getLogger(this.getClass());
private final boolean isDebugEnabled = logger.isDebugEnabled();

Check warning on line 43 in exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java

View check run for this annotation

Codecov / codecov/patch

exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java#L43 

Added line #L43 was not covered by tests

private final KafkaTemplate<String, ExceptionMetaDataEntity> kafkaExceptionMetaDataTemplate;

Expand All @@ -64,11 +65,16 @@
@Override
public void insert(List<ExceptionMetaData> exceptionMetaData) {
Objects.requireNonNull(exceptionMetaData);
logger.info("Pinot data insert: {}", exceptionMetaData);

if (isDebugEnabled) {
logger.debug("Pinot data insert: {}", exceptionMetaData);

Check warning on line 70 in exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java

View check run for this annotation

Codecov / codecov/patch

exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java#L70 

Added line #L70 was not covered by tests
}

for (ExceptionMetaData e : exceptionMetaData) {
ExceptionMetaDataEntity dataEntity = mapper.toEntity(e);
logger.info("data insert {}", dataEntity);
if (isDebugEnabled) {
logger.debug("data insert {}", dataEntity);

Check warning on line 76 in exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java

View check run for this annotation

Codecov / codecov/patch

exceptiontrace/exceptiontrace-collector/src/main/java/com/navercorp/pinpoint/exceptiontrace/collector/dao/PinotExceptionTraceDao.java#L76 

Added line #L76 was not covered by tests
}
CompletableFuture<SendResult<String, ExceptionMetaDataEntity>> response = this.kafkaExceptionMetaDataTemplate.send(
topic, dataEntity
);
Expand Down
10 changes: 4 additions & 6 deletions ...est/java/com/navercorp/pinpoint/exceptiontrace/web/model/ExceptionTraceValueViewTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,21 @@ void testGetFieldName() {
GroupedFieldName emptyFieldName = new GroupedFieldName();
emptyFieldName.setErrorMessage("");
view.setGroupedFieldName(emptyFieldName);

assertEquals(ExceptionTraceValueView.EMPTY_STRING, view.getFieldName());


GroupedFieldName nullStringFieldName = new GroupedFieldName();
emptyFieldName.setErrorMessage("null");
view.setGroupedFieldName(emptyFieldName);
nullStringFieldName.setErrorMessage("null");
view.setGroupedFieldName(nullStringFieldName);
assertEquals("null", view.getFieldName());

assertEquals(ExceptionTraceValueView.EMPTY_STRING, view.getFieldName());

GroupedFieldName nullFieldName = new GroupedFieldName();
view.setGroupedFieldName(nullFieldName);

assertEquals(ExceptionTraceValueView.TOTAL_FIELDNAME, view.getFieldName());


view.setGroupedFieldName(null);

assertEquals(ExceptionTraceValueView.TOTAL_FIELDNAME, view.getFieldName());
}
}
Loading