[#noissue] fix servermap numaric display #10931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BillionaireDY
commented
Apr 18, 2024
BillionaireDY
commented
- display
- node instance count
- unit of average response time (ms)
binDongKim
requested changes
Apr 24, 2024
| const { transactionInfo } = nodeData; | ||
| const transactionStatus = getTransactionStatusSVGCircle(transactionInfo, !transactionInfo); |
There was a problem hiding this comment.
Suggested change
| const transactionStatus = getTransactionStatusSVGCircle(transactionInfo, !transactionInfo); | |
| const transactionStatusSVGString = getTransactionStatusSVGCircle(transactionInfo, !transactionInfo); |
| return ( | ||
| 'data:image/svg+xml;charset=utf-8,' + | ||
| encodeURIComponent(` | ||
| <svg xmlns="http://www.w3.org/2000/svg" width="100" height="100" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| ${getTransactionStatusSVGCircle(transactionInfo, !transactionInfo)} | ||
| ${renderNode ? renderNode(nodeData, transactionStatus) : transactionStatus} |
There was a problem hiding this comment.
Suggested change
| ${renderNode ? renderNode(nodeData, transactionStatus) : transactionStatus} | |
| ${renderNode ? renderNode(nodeData, transactionStatusSVGString) : transactionStatusSVGString} |
| renderEdgeLabel={(edge: MergedEdge) => { | ||
| if (edge?.transactionInfo?.totalCount) { | ||
| return `${addCommas(edge?.transactionInfo?.totalCount)}${edge.transactionInfo?.avgResponseTime ? ` (${edge.transactionInfo.avgResponseTime} ms)` : ''}`; | ||
| } else if (edge.edges) { |
There was a problem hiding this comment.
Suggested change
| } else if (edge.edges) { | |
| } else if (edge?.edges) { |
BillionaireDY
force-pushed
the
fix-servermap-numaric-display
branch
from
fe41d0a
to
7cac84d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.