Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] refactor collector span sampling #11015

Merged
merged 1 commit into from
May 16, 2024

Conversation

donghun-cho
Copy link
Contributor

add span sampling properties to pinpoint banner

@donghun-cho donghun-cho self-assigned this May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 37.02%. Comparing base (d242ae3) to head (2a60bf1).
Report is 3 commits behind head on master.

Files Patch % Lines
...pinpoint/collector/config/CollectorProperties.java 0.00% 4 Missing ⚠️
...nt/collector/sampler/SimpleSpanSamplerFactory.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11015      +/-   ##
============================================
- Coverage     37.03%   37.02%   -0.01%     
+ Complexity    11988    11970      -18     
============================================
  Files          3937     3936       -1     
  Lines         97066    97007      -59     
  Branches      10395    10398       +3     
============================================
- Hits          35947    35920      -27     
+ Misses        58165    58132      -33     
- Partials       2954     2955       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donghun-cho donghun-cho merged commit e66746b into pinpoint-apm:master May 16, 2024
3 checks passed
@donghun-cho donghun-cho deleted the collectorSampler branch May 28, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant