Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10704] change the servicetype code to servicecode name for readability. #11020

Merged
merged 1 commit into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
/*
* Copyright 2024 NAVER Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.navercorp.pinpoint.inspector.web.definition.metric;

import com.navercorp.pinpoint.inspector.web.model.InspectorMetricValue;
import com.navercorp.pinpoint.loader.service.ServiceTypeRegistryService;
import com.navercorp.pinpoint.metric.common.model.Tag;
import org.springframework.stereotype.Component;

import java.util.ArrayList;
import java.util.List;

/**
* @author minwoo-jung
*/
@Component
public class ServiceTypeMatchingPostProcessor implements MetricPostProcessor {

public static final String SERVICE_TYPE = "serviceType";
private static final String SERVICE_TYPE_CODE = "serviceTypeCode";
private final ServiceTypeRegistryService serviceTypeRegistryService;

public ServiceTypeMatchingPostProcessor(ServiceTypeRegistryService serviceTypeRegistryService) {
this.serviceTypeRegistryService = serviceTypeRegistryService;
}

Check warning on line 39 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L37-L39

Added lines #L37 - L39 were not covered by tests

@Override
public String getName() {
return "matchingServiceType";

Check warning on line 43 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L43

Added line #L43 was not covered by tests
}

@Override
public List<InspectorMetricValue> postProcess(List<InspectorMetricValue> metricValueList) {
if (metricValueList.isEmpty()) {
return metricValueList;

Check warning on line 49 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L49

Added line #L49 was not covered by tests
}

List<InspectorMetricValue> newMetricValueList = new ArrayList<>(metricValueList.size());

Check warning on line 52 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L52

Added line #L52 was not covered by tests

for(InspectorMetricValue inspectorMetricValue : metricValueList) {
List<Tag> tagList = changeServiceTypeCodeToName(inspectorMetricValue.getTagList());
newMetricValueList.add(new InspectorMetricValue(inspectorMetricValue.getFieldName(),

Check warning on line 56 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L55-L56

Added lines #L55 - L56 were not covered by tests
tagList,
inspectorMetricValue.getChartType(),
inspectorMetricValue.getUnit(),
inspectorMetricValue.getValueList()));
}

Check warning on line 61 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L58-L61

Added lines #L58 - L61 were not covered by tests

return newMetricValueList;

Check warning on line 63 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L63

Added line #L63 was not covered by tests
}

private List<Tag> changeServiceTypeCodeToName(List<Tag> tagList) {
List<Tag> newTagList = new ArrayList<>(tagList.size());

Check warning on line 67 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L67

Added line #L67 was not covered by tests

for (Tag tag : tagList) {
if (tag.getName().equals(SERVICE_TYPE_CODE)) {
short serviceTypeCode = Short.parseShort(tag.getValue());
String serviceTypeName = serviceTypeRegistryService.findServiceType(serviceTypeCode).getName();
newTagList.add(new Tag(SERVICE_TYPE, serviceTypeName));
} else {
newTagList.add(tag);

Check warning on line 75 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L71-L75

Added lines #L71 - L75 were not covered by tests
}
}

Check warning on line 77 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L77

Added line #L77 was not covered by tests

return newTagList;

Check warning on line 79 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/definition/metric/ServiceTypeMatchingPostProcessor.java#L79

Added line #L79 was not covered by tests
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@
}

List<InspectorMetricValue> inspectorMetricValueList = new ArrayList<>(2);
inspectorMetricValueList.add(new InspectorMetricValue("AVG", field.getTags(), field.getChartType(), field.getUnit(), avgValueList));
inspectorMetricValueList.add(new InspectorMetricValue("MIN", field.getTags(), field.getChartType(), field.getUnit(), minValueList));
inspectorMetricValueList.add(new InspectorMetricValue("AVG", field.getTags(), field.getChartType(), field.getUnit(), avgValueList));

Check warning on line 194 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/service/DefaultApplicationStatService.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/service/DefaultApplicationStatService.java#L194

Added line #L194 was not covered by tests
return inspectorMetricValueList;
}

Expand All @@ -210,8 +210,8 @@
}

List<InspectorMetricValue> inspectorMetricValueList = new ArrayList<>(3);
inspectorMetricValueList.add(new InspectorMetricValue("AVG", field.getTags(), field.getChartType(), field.getUnit(), avgValueList));
inspectorMetricValueList.add(new InspectorMetricValue("MIN", field.getTags(), field.getChartType(), field.getUnit(), minValueList));
inspectorMetricValueList.add(new InspectorMetricValue("AVG", field.getTags(), field.getChartType(), field.getUnit(), avgValueList));

Check warning on line 214 in inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/service/DefaultApplicationStatService.java

View check run for this annotation

Codecov / codecov/patch

inspector-module/inspector-web/src/main/java/com/navercorp/pinpoint/inspector/web/service/DefaultApplicationStatService.java#L214

Added line #L214 was not covered by tests
inspectorMetricValueList.add(new InspectorMetricValue("MAX", field.getTags(), field.getChartType(), field.getUnit(), maxValueList));
return inspectorMetricValueList;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ mappings:
title: "Data Source"
grouping: "TAG"
preProcess: "usingDataSourceTagForAgent"
postProcess: "matchingServiceType"
fields:
- fieldName: "activeConnectionSize"
fieldAlias: "activeAvg"
Expand Down
Loading