Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Support colon-base time format #11223

Merged

Conversation

binDongKim
Copy link
Contributor

No description provided.

@binDongKim binDongKim requested a review from BillionaireDY July 4, 2024 10:03
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.99%. Comparing base (ae66fc2) to head (8f491ab).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11223      +/-   ##
============================================
- Coverage     36.99%   36.99%   -0.01%     
- Complexity    12047    12053       +6     
============================================
  Files          3980     3983       +3     
  Lines         97903    97956      +53     
  Branches      10418    10426       +8     
============================================
+ Hits          36220    36235      +15     
- Misses        58709    58745      +36     
- Partials       2974     2976       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BillionaireDY BillionaireDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

web-frontend/src/main/v3/packages/constants/src/date.ts Outdated Show resolved Hide resolved
@binDongKim binDongKim force-pushed the support-colon-time-format branch from 8f491ab to 337bd0d Compare July 8, 2024 03:08
@binDongKim binDongKim merged commit 39b0476 into pinpoint-apm:master Jul 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants