Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11503] Remove duplicate code in SimpleCache #11504

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Sep 20, 2024

No description provided.

@emeroad emeroad added this to the 3.0.1 milestone Sep 20, 2024
@emeroad emeroad linked an issue Sep 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 37.08%. Comparing base (ed3b57c) to head (9697d69).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...navercorp/pinpoint/profiler/cache/SimpleCache.java 85.71% 2 Missing ⚠️
...pinpoint/profiler/test/MockApiMetaDataService.java 0.00% 1 Missing ⚠️
.../com/navercorp/pinpoint/profiler/cache/Result.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11504      +/-   ##
============================================
- Coverage     37.10%   37.08%   -0.03%     
+ Complexity    12193    12186       -7     
============================================
  Files          4014     4013       -1     
  Lines         98632    98594      -38     
  Branches      10423    10419       -4     
============================================
- Hits          36600    36563      -37     
  Misses        59050    59050              
+ Partials       2982     2981       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad merged commit 6fea585 into pinpoint-apm:master Sep 20, 2024
3 checks passed
@emeroad emeroad deleted the #11503_simplecache branch September 20, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate code in SimpleCache
1 participant