Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2862] refactor scope #2911

Merged
merged 1 commit into from
May 11, 2017

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented May 11, 2017

[#2862]

@emeroad emeroad added this to the 1.6.2 milestone May 11, 2017
@codecov-io
Copy link

codecov-io commented May 11, 2017

Codecov Report

Merging #2911 into 1.6.x will increase coverage by 0.04%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##            1.6.x    #2911      +/-   ##
==========================================
+ Coverage   36.73%   36.77%   +0.04%     
==========================================
  Files        1778     1780       +2     
  Lines       61427    61414      -13     
  Branches     8601     8594       -7     
==========================================
+ Hits        22565    22586      +21     
+ Misses      36483    36448      -35     
- Partials     2379     2380       +1
Impacted Files Coverage Δ
.../pinpoint/profiler/instrument/JavassistMethod.java 6.27% <0%> (+0.45%) ⬆️
...ercorp/pinpoint/profiler/instrument/ScopeInfo.java 100% <100%> (ø)
...ercorp/pinpoint/profiler/instrument/ASMMethod.java 49.24% <100%> (-3.39%) ⬇️
...terceptor/factory/AnnotatedInterceptorFactory.java 27.65% <66.66%> (+1.61%) ⬆️
...orp/pinpoint/profiler/instrument/ScopeFactory.java 95% <95%> (ø)
...tor/metric/datasource/DefaultDataSourceMetric.java 69.69% <0%> (-3.04%) ⬇️
...m/navercorp/pinpoint/test/OrderedSpanRecorder.java 70.93% <0%> (-2.33%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 75.37% <0%> (-0.76%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748d995...a320875. Read the comment docs.

@emeroad emeroad force-pushed the #2862_workaround_deaklock_scope branch from ea7c14c to a320875 Compare May 11, 2017 10:02
@emeroad emeroad merged commit f7f6bcb into pinpoint-apm:1.6.x May 11, 2017
@emeroad emeroad deleted the #2862_workaround_deaklock_scope branch May 15, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants