-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support export trace info to app for external usage #6801
Conversation
a4881f9
to
01afe4e
Compare
Codecov Report
@@ Coverage Diff @@
## master #6801 +/- ##
==========================================
- Coverage 39.23% 39.18% -0.05%
==========================================
Files 3195 3199 +4
Lines 94770 94862 +92
Branches 11844 11861 +17
==========================================
- Hits 37179 37175 -4
- Misses 54612 54706 +94
- Partials 2979 2981 +2
Continue to review full report at Codecov.
|
@yjqg6666 |
It would not affect the application, just no write only read, null TraceInfo/TransactionId would be return. |
Have tested and checked that the above three variables would always be null if no pinpoint in javaagent or the request is not sampled. The package com.navercorp.pinpoint:pinpoint-application-interaction must have no extra dependency introduced. |
af2697b
to
7a30355
Compare
Feature
Export txId & spanId to application. Disabled by default.
Usage
If my application need to save/notify some system the txId/spanId, i could
Scene
In kafka lower version client/broker which do not support KAFKA header, now we could get the txId & spanId and put these info into message body, then the consumer can get the trace info and log. Now i can also save txId & my biz id(order id/user id etc) to db together.
Before this PR, we could only get the txId/spanId from slf4j.MDC in a hacky way.