Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9932] Reduce pinpoint-rpc dependency #9931

Merged
merged 1 commit into from
May 15, 2023

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented May 11, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #9931 (0daf068) into master (d9ef155) will decrease coverage by 0.03%.
The diff coverage is 51.74%.

@@             Coverage Diff              @@
##             master    #9931      +/-   ##
============================================
- Coverage     38.86%   38.83%   -0.03%     
+ Complexity    11907    11877      -30     
============================================
  Files          3538     3536       -2     
  Lines         93995    93832     -163     
  Branches      10496    10473      -23     
============================================
- Hits          36528    36437      -91     
+ Misses        54296    54236      -60     
+ Partials       3171     3159      -12     
Impacted Files Coverage Δ
...point/collector/cluster/ThriftAgentConnection.java 66.66% <ø> (ø)
...t/collector/cluster/route/DefaultRouteHandler.java 35.71% <0.00%> (-1.79%) ⬇️
...t/collector/controller/ClusterPointController.java 0.00% <0.00%> (ø)
...com/navercorp/pinpoint/test/TestTcpDataSender.java 0.00% <ø> (ø)
...corp/pinpoint/profiler/sender/EmptyDataSender.java 50.00% <ø> (+10.00%) ⬆️
...rp/pinpoint/profiler/sender/LoggingDataSender.java 16.66% <ø> (+4.16%) ⬆️
...point/profiler/sender/WriteFailFutureListener.java 75.00% <0.00%> (+5.00%) ⬆️
...oint/profiler/sender/grpc/AgentGrpcDataSender.java 0.00% <0.00%> (ø)
...t/profiler/sender/grpc/MetadataGrpcDataSender.java 0.00% <ø> (ø)
...vercorp/pinpoint/web/service/AgentServiceImpl.java 0.00% <0.00%> (ø)
... and 15 more

... and 6 files with indirect coverage changes

@emeroad emeroad linked an issue May 12, 2023 that may be closed by this pull request
@emeroad emeroad changed the title [#noissue] Reduce pinpoint-rpc dependency [#9932] Reduce pinpoint-rpc dependency May 12, 2023
@emeroad emeroad added this to the 2.6.0 milestone May 12, 2023
@emeroad emeroad force-pushed the #noissue_reduce_thrift branch 5 times, most recently from c3cf897 to 92a1bee Compare May 15, 2023 08:46
@emeroad emeroad merged commit de1949e into pinpoint-apm:master May 15, 2023
@emeroad emeroad deleted the #noissue_reduce_thrift branch May 17, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thrift transport End of Life Support
1 participant