Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9932] Remove thrift dependency of Agent module #9941

Merged
merged 1 commit into from
May 23, 2023

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented May 17, 2023

No description provided.

@emeroad emeroad added this to the 2.6.0 milestone May 17, 2023
@emeroad emeroad force-pushed the #9932_thrift branch 7 times, most recently from 1d70352 to e2cc965 Compare May 18, 2023 10:05
@emeroad emeroad changed the title [#9932] Removed thrift dependency of Agent module [#9932] Remove thrift dependency of Agent module May 18, 2023
@emeroad emeroad force-pushed the #9932_thrift branch 2 times, most recently from 6a8d5f1 to b956293 Compare May 19, 2023 02:23
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #9941 (da60ef9) into master (97fc92a) will increase coverage by 0.22%.
The diff coverage is 28.43%.

@@             Coverage Diff              @@
##             master    #9941      +/-   ##
============================================
+ Coverage     38.81%   39.03%   +0.22%     
+ Complexity    11995    11794     -201     
============================================
  Files          3627     3592      -35     
  Lines         95141    93857    -1284     
  Branches      10521    10381     -140     
============================================
- Hits          36926    36638     -288     
+ Misses        55056    54069     -987     
+ Partials       3159     3150       -9     
Impacted Files Coverage Δ
...oint/collector/cluster/ClusterPointRepository.java 58.82% <ø> (ø)
...inpoint/collector/cluster/GrpcAgentConnection.java 28.12% <ø> (-43.75%) ⬇️
...point/collector/cluster/ThriftAgentConnection.java 66.66% <ø> (ø)
...r/cluster/flink/FlinkClusterConnectionManager.java 0.00% <ø> (ø)
...inpoint/collector/cluster/flink/SenderContext.java 0.00% <ø> (ø)
...llector/cluster/flink/TcpDataSenderRepository.java 0.00% <ø> (ø)
...t/collector/cluster/route/DefaultRouteHandler.java 35.71% <ø> (ø)
...nt/collector/cluster/route/StreamRouteHandler.java 0.00% <ø> (ø)
...t/collector/controller/ClusterPointController.java 0.00% <ø> (ø)
...nt/collector/receiver/grpc/PinpointGrpcServer.java 47.39% <ø> (ø)
... and 120 more

... and 67 files with indirect coverage changes

@emeroad emeroad force-pushed the #9932_thrift branch 6 times, most recently from 8a44f2e to da60ef9 Compare May 23, 2023 01:49
@emeroad emeroad merged commit b086e4d into pinpoint-apm:master May 23, 2023
@emeroad emeroad deleted the #9932_thrift branch May 24, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant