Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SideNavigation, Tabs, DefaultLabelProvider: implemented Indicator #3901

Merged
merged 4 commits into from
Dec 2, 2024
Merged

SideNavigation, Tabs, DefaultLabelProvider: implemented Indicator #3901

merged 4 commits into from
Dec 2, 2024

Conversation

AlbertCarreras
Copy link
Contributor

@AlbertCarreras AlbertCarreras commented Dec 2, 2024 •
edited
Loading

Breaking change

New label in DefaultLabelsProvider

  Tabs: {
    accessibilityNotificationLabel: myI18nTranslator(
      'This tab is displaying a notification indicator',
    ),

SideNavigation, Tabs, DefaultLabelProvider: implemented Indicator

Component BEFORE AFTER
Tabs Screenshot by Dropbox Capture Screenshot by Dropbox Capture
SideNavigation Screenshot by Dropbox Capture Screenshot by Dropbox Capture
SideNavigation collapsed Screenshot by Dropbox Capture Screenshot by Dropbox Capture

@AlbertCarreras AlbertCarreras added the minor release Minor release label Dec 2, 2024
@AlbertCarreras AlbertCarreras requested a review from a team as a code owner December 2, 2024 20:47
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024

✅ Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit 8687550
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/674e1ccc1474da00080b1c0d
😎 Deploy Preview https://deploy-preview-3901--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit d3bd9f2
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/674e2e00204e7200088dff9e
😎 Deploy Preview https://deploy-preview-3901--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlbertCarreras AlbertCarreras added major release Major release and removed minor release Minor release labels Dec 2, 2024
@AlbertCarreras AlbertCarreras changed the title SideNavigation, Tabs: implemented Indicator SideNavigation, Tabs, DefaultLabelProvider: implemented Indicator Dec 2, 2024
@AlbertCarreras AlbertCarreras merged commit 604071c into pinterest:master Dec 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eniomoura eniomoura eniomoura approved these changes

Assignees
No one assigned
Labels
major release Major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlbertCarreras @eniomoura