Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make exception to function-naming rule for override #2271

Closed
diasDominik opened this issue Sep 21, 2023 · 1 comment · Fixed by #2274
Closed

make exception to function-naming rule for override #2271

diasDominik opened this issue Sep 21, 2023 · 1 comment · Fixed by #2274
Assignees
@paul-dingemans
Labels
function-naming rule up-for-grabs
Milestone
1.0.1

Comments

@diasDominik
Copy link

Expected Behavior

for override functions the function-naming rule should not apply as it is possible that you don't have control over the naming of that function as you override it from e.g. external lib.
override fun Foo() does not trigger the function naming rule

Current Behavior

override fun Foo() does trigger the function naming rule

Additional information

  • Current version of ktlint: 1.0.0
@paul-dingemans
Copy link
Collaborator

Good suggestion. Tnx

@paul-dingemans paul-dingemans added this to the 1.0.1 milestone Sep 23, 2023
@paul-dingemans paul-dingemans self-assigned this Sep 23, 2023
paul-dingemans added a commit that referenced this issue Sep 23, 2023
@paul-dingemans
Ignore override of function in rule function-naming
52d3d16 
A function override should not be reported as the interface of class that defines the function might be out of scope of the project in which case the function name can not be changed. Note that the function will still be reported at the interface or class itself whenever that interface or class is defined inside the scope of the project.

Closes #2271
@paul-dingemans paul-dingemans mentioned this issue Sep 23, 2023
Merged
9 tasks
paul-dingemans added a commit that referenced this issue Sep 23, 2023
@paul-dingemans
Ignore override of function in rule function-naming (#2274)
fac432f 
A function override should not be reported as the interface of class that defines the function might be out of scope of the project in which case the function name can not be changed. Note that the function will still be reported at the interface or class itself whenever that interface or class is defined inside the scope of the project.

Closes #2271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paul-dingemans paul-dingemans

Labels
function-naming rule up-for-grabs
Projects
None yet
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

Ignore override of function in rule function-naming pinterest/ktlint
2 participants
@paul-dingemans @diasDominik