-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize console output color? #582
Comments
Well it wouldn't be very plain then, would it? :) I don't have strong feelings about this either way - you could easily write another custom reporter with nice colors, or this could be customizable...maybe by passing a color to the |
I like that idea! I notice we already have a bunch of colors defined here: https://github.com/pinterest/ktlint/blob/master/ktlint-reporter-plain/src/main/kotlin/com/pinterest/ktlint/reporter/plain/internal/Color.kt Ideally I could reference these, and maybe we can do I don't know much about how KtLint works now and it may take me a while to figure out how to implement this but I will try. If anyone sees this and knows a quick way to the solution feel free to take it from me. :) |
… have a color injected rather than define one itself.
…is was easiest without causing a breaking change around color for pinterest#582.
Here's my take on that: #585 |
…uldn't parse a color, and updated tests for pinterest#582.
Closed via #585 |
I was looking at the console logs of one of my builds recently that had KtLint errors, and at first they didn't stand out to me. I have the color option on, but noticed that when we color things, they're gray by default: https://github.com/pinterest/ktlint/blob/master/ktlint-reporter-plain/src/main/kotlin/com/pinterest/ktlint/reporter/plain/PlainReporter.kt#L56
Against a black console, this doesn't really stand out to me. Other code quality tools like Detekt will output these using a sharper color like yellow.
I'm curious if we could change the color to something that stands out a little more against a dark console, or if the output color is something that could be customized?
An example of how hard this was to read:
Comparison to Detekt:
The text was updated successfully, but these errors were encountered: