Fix formatting with comments (colon-spacing)
#1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tapchicoma
reviewed
Jan 15, 2021
Comment on lines
291
to
292
| val x: // comment | ||
| Int = 1 |
There was a problem hiding this comment.
Not sure it is the best way to format 🤔
Property type should be, imho, on the same line with property name. Probably formatted code could look like this:
val x: Int = // comment
1or like this:
// comment
val x: Int = 1What do you think?
There was a problem hiding this comment.
val x: Int = // comment 1
I think this is better.
Fixed in e36aebf.
t-kameyama
force-pushed
the
issue_1057
branch
2 times, most recently
from
bedc883 to
8b37d87
Compare
t-kameyama
force-pushed
the
issue_1057
branch
from
8b37d87 to
75f3bc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1057
Checklist
CHANGELOG.mdis updated