Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all function bodies with body expressions in a single run #2395

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

paul-dingemans
Copy link
Collaborator

Description

If a file contains multiple function bodies that have to be replaced with a body expression, then all should be replaced with a single run of ktlint.

Closes #2394

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

If a file contains multiple function bodies that have to be replaced with a body expression, then all should be replaced with a single run of ktlint.

Closes #2394
@paul-dingemans paul-dingemans added this to the 1.1 milestone Nov 30, 2023
@paul-dingemans paul-dingemans merged commit 647e795 into master Dec 2, 2023
12 checks passed
@paul-dingemans paul-dingemans deleted the 2394-function-expression-body branch December 2, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FunctionExpressionBodyRule should replace all expression bodies in a single run
1 participant