Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapping of expression body when max_line_length not set #2833

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

This fixes the wrapping of the expression for code style intellij_idea which does not set the max_line_length property by default. But it also fixes the wrapping in case the max_line_length property contains value unset for any of the code styles.

Closes #2827

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

This fixes the wrapping of the expression for code style `intellij_idea` which does not set the `max_line_length` property by default. But it also fixes the wrapping in case the `max_line_length` property contains value `unset` for any of the code styles.

Closes #2827
@paul-dingemans paul-dingemans added this to the 1.4.0 milestone Oct 13, 2024
@paul-dingemans paul-dingemans merged commit 4a7e9d7 into master Oct 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ktlint_function_signature_body_expression_wrapping = always doesn't always apply
1 participant