Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive when empty parameter list is in between trailing lambda's of a nested call expression #2891

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Fix false positive when empty parameter list is in between trailing lambda's of a nested call expression

Given code below:

fun fooBar(foo: () -> String): (() -> String) -> String = { bar -> foo().plus("  ").plus(bar()) }

val foobar = fooBar { "Hello" }() { "world" }

then the empty parameter list may ot be removed as it results in a compile error.

Closes #2884

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@paul-dingemans paul-dingemans added this to the 1.5 milestone Dec 3, 2024
@paul-dingemans paul-dingemans merged commit 1bc924c into master Dec 3, 2024
10 checks passed
@paul-dingemans paul-dingemans deleted the 2884 branch December 3, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for standard:unnecessary-parentheses-before-trailing-lambda
1 participant