Add "printAST" sub command. #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move old one (--print-ast) option to be a ktlint sub command - new syntax: `ktlint printAST`. Old one `--print-ast` is still working, but deprecated. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
romtsn
reviewed
Jun 23, 2019
| } | ||
|
|
||
| companion object { | ||
| internal const val COMMAND_NAME = "printAST" |
There was a problem hiding this comment.
May I ask what's the reasoning behind using a camel-cased command name instead of good old '--do-something' pattern for CLI tools? The old way just looks more natural imo.
There was a problem hiding this comment.
Main reason to move into subcommands direction - reduce user confusion and make command line usage more clear.
For example, now with only options, it is not clear if using --print-ast option will also do linting.
Though I am open to subcommand name changes as I don't have strong opinion here.
sowmyav24
pushed a commit
to sowmyav24/ktlint
that referenced
this pull request
Jul 18, 2019
Move old one (--print-ast) option to be a ktlint sub command - new syntax: `ktlint printAST`. Old one `--print-ast` is still working, but deprecated. Signed-off-by: Yahor Berdnikau <egorr.berd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move old one (--print-ast) option to be a ktlint sub command - new syntax:
ktlint printAST. Old one--print-astis still working, butdeprecated.