Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndentationRule: Do not enforce raw strings opening quote to be on a separate line #849

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

romtsn
Copy link
Collaborator

@romtsn romtsn commented Aug 22, 2020

Fixes #711

@shashachu I saw you've introduced this change in b54ea78 but I think we should just leave raw strings alone because IDEA also does nothing about them (at least I haven't found any pattern) neither there are any mentions about it in the style guides

@romtsn romtsn force-pushed the fix/dont-enforce-raw-strings branch from c67f931 to 12e079f Compare August 22, 2020 20:23
@shashachu
Copy link
Contributor

Haha I don't remember why I made that change to be honest. I do wonder if we might be able to differentiate between multiline raw strings and single line raw strings (where I agree the ktlint formatting is broken). But for now we can just revert that change.

@shashachu shashachu merged commit df3020e into pinterest:master Aug 24, 2020
@romtsn romtsn deleted the fix/dont-enforce-raw-strings branch August 24, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raw strings forced on a separate line by indent rule
2 participants