Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IndentationRule: don't insert unnecessary spacings inside multiline if-else condition #949

Merged
merged 1 commit into from
Oct 25, 2020
Merged

IndentationRule: don't insert unnecessary spacings inside multiline if-else condition #949

merged 1 commit into from
Oct 25, 2020
+45 −1

Conversation

t-kameyama
Copy link
Contributor

@t-kameyama t-kameyama commented Oct 24, 2020 •
edited
Loading

Fixes #871
Fixes #900

@t-kameyama
IndentationRule: don't insert unnecessary spacings inside multiline i…
1615984 
…f-else condition

Don't increment `expectedIndent` if there is a line break after condition left parentheses
@romtsn romtsn merged commit 6ae2726 into pinterest:master Oct 25, 2020
@t-kameyama t-kameyama deleted the issue_871 branch October 25, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@t-kameyama @romtsn