Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Java enum rendering to avoid collisions with multiple enums #130

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Update Java enum rendering to avoid collisions with multiple enums #130

merged 1 commit into from
Mar 16, 2018

Conversation

rahul-malik
Copy link
Collaborator

Addresses #129

@rahul-malik rahul-malik self-assigned this Mar 16, 2018
@ghost
Copy link

ghost commented Mar 16, 2018

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

NightlyNexus
NightlyNexus approved these changes Mar 16, 2018
View reviewed changes
Copy link

@NightlyNexus NightlyNexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output lgtm. thanks!

@rahul-malik rahul-malik merged commit 42838c3 into master Mar 16, 2018
@jparise jparise deleted the rmalik-fix-java-enum-collision branch January 3, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NightlyNexus NightlyNexus NightlyNexus approved these changes

Assignees

@rahul-malik rahul-malik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahul-malik @NightlyNexus