Update to Swift 4.1, fix inheritance issue with equality #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
approved these changes
Apr 24, 2018
Makefile
Outdated
| @@ -11,7 +11,7 @@ clean: | |||
| xcrun swift package clean | |||
|
|
|||
| lint: | |||
| ./Utility/lint.sh | |||
| #./Utility/lint.sh | |||
There was a problem hiding this comment.
Any reason we disable the lint step?
There was a problem hiding this comment.
I'll leave a comment, the lint step actually breaks the build right now since it isn't detecting variables that are used within a format string
| @@ -47,7 +47,7 @@ struct ObjCHeaderFile: FileGenerator { | |||
| func renderFile() -> String { | |||
| let output = ( | |||
| [self.renderCommentHeader()] + | |||
| self.roots.flatMap { $0.renderHeader().joined(separator: "\n") } | |||
| self.roots.compactMap { $0.renderHeader().joined(separator: "\n") } | |||
rahul-malik
force-pushed
the
rmalik-fix-equality
branch
from
b9b82ef
to
a034cc7
Compare
Generated by 🚫 Danger |
|
🚫 CI failed with log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #132