For Boolean, Double and Integer properties, getters should be NonNull #178
Conversation
|
@rahul-malik Probably easiest if you review and (hopefully) merge #177 first |
Sources/Core/JavaModelRenderer.swift
Outdated
| ] | ||
| } | ||
| default: | ||
| return JavaIR.method([.public], typeFromSchema(param, schemaObj) + " get" + param.snakeCaseToCapitalizedPropertyName() + "()") { [ | ||
| "return this." + param.snakeCaseToPropertyName() + ";", |
There was a problem hiding this comment.
same with param.snakeCaseToPropertyName()
Sources/Core/JavaFileRenderer.swift
Outdated
| @@ -49,6 +49,56 @@ extension JavaFileRenderer { | |||
| } | |||
| } | |||
|
|
|||
| func wrappedClassNameFromSchema(_ param: String, _ schema: Schema) -> String { | |||
There was a problem hiding this comment.
Is this method used anywhere?
|
@RicoYao - I'll likely merge the PR that builds Java code tomorrow if you'd like to take a look #176 Basically did the work to get the Java example fixtures building on CI and fixed small issues along the way to get it working. If you get yourself added to the Pinterest Github organization I can add you as a reviewer |
Will do. I am in the Pinterest Github organization now. |
|
@RicoYao - Please rebase master and resolve the conflicts when you get a chance. I just merged the changes for CI to build the java examples so you should see that when you rebase / update this PR 👍 |
Otherwise callers will always have to defend against null values, which is a big pain. We have isVARIABLESet() methods if developers want to check if a property was actually set or not.
RicoYao
force-pushed
the
null_friendliness
branch
from
9659f11
to
adfa6a5
Compare
|
@RicoYao - I'll merge after CI passes |
Otherwise callers will always have to defend against null values, which is a big pain.
We have isVARIABLESet() methods if developers want to check if a property was actually set or not.