Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use ObjectiveC-based handling of reserved keywords for Java #187

Merged
merged 11 commits into from
Mar 20, 2019
Merged

Don't use ObjectiveC-based handling of reserved keywords for Java #187

merged 11 commits into from
Mar 20, 2019

Commits on Mar 19, 2019

  1. Don't use ObjectiveC-based handling of reserved keywords for Java 

    - Java has its own set of different reserved keywords.
- Also use a "uid" property name for "id" (ObjC uses "identifier). This is pinterest-specific and we may have to add in a custom override for this instead later.
    @RicoYao
    RicoYao committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    c23556e View commit details
    Browse the repository at this point in the history

  2. Move snakeCaseToPropertyName/CapitalizaedPropertyName/CamelCase into … 

    …Languages enum
    @RicoYao
    RicoYao committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    1b81b68 View commit details
    Browse the repository at this point in the history

  3. Remove StringExtension methods that are now in Languages. Fixed a few… 

    … stragglers. make format/lint.
    @RicoYao
    RicoYao committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    d4e04a8 View commit details
    Browse the repository at this point in the history

  4. Fix tests.

    @RicoYao
    RicoYao committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    c3646ff View commit details
    Browse the repository at this point in the history

  5. make format

    @RicoYao
    RicoYao committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    71fd8c1 View commit details
    Browse the repository at this point in the history

  6. fix LinuxTestIndex

    @RicoYao
    RicoYao committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    6ed6ccd View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. make format

    @RicoYao
    RicoYao committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    7d9d24f View commit details
    Browse the repository at this point in the history

  2. Add tests for renaming of "id" fields in java and objC

    @RicoYao
    RicoYao committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    9980d50 View commit details
    Browse the repository at this point in the history

  3. make format

    @RicoYao
    RicoYao committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    e51fefe View commit details
    Browse the repository at this point in the history

  4. Add linux test indexes (make build_test_index_linux)

    @RicoYao
    RicoYao committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    13cd190 View commit details
    Browse the repository at this point in the history

  5. make format to fix the linux test indexes

    @RicoYao
    RicoYao committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    f8f7af3 View commit details
    Browse the repository at this point in the history