Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix archive command to work also with Swift 5 #200

Merged
merged 1 commit into from
May 15, 2019
Merged

Fix archive command to work also with Swift 5 #200

merged 1 commit into from
May 15, 2019

Conversation

RicoYao
Copy link
Contributor

@RicoYao RicoYao commented May 10, 2019

This will trigger a warning for those on >= MacOS 10.14.4 but it will get it working again.

warning: Swift compiler no longer supports statically linking the Swift libraries. They're included in the OS by default starting with macOS Mojave 10.14.4. For macOS Mojave 10.14.3 and earlier, there's an optional Swift library package that can be downloaded from "More Downloads" for Apple Developers at https://developer.apple.com/download/more/

@RicoYao RicoYao requested a review from rahul-malik May 10, 2019 23:56
@RicoYao RicoYao force-pushed the fix_swift5_archive_command branch from ba057f1 to d63bfad Compare May 14, 2019 21:42
@RicoYao RicoYao force-pushed the fix_swift5_archive_command branch from d63bfad to 9dc0bea Compare May 14, 2019 22:12
@rahul-malik
Copy link
Collaborator

Thanks for fixing!

@rahul-malik rahul-malik merged commit a2d1022 into pinterest:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul-malik rahul-malik rahul-malik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RicoYao @rahul-malik