Invalid call to Builder-setter from Java TypeAdapter #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setter method name was not correctly generated in the TypeAdapter. Added a field to board.json example to surface the issue, and ensure tests catch it.
RicoYao
commented
May 22, 2019
| @@ -176,7 +176,7 @@ public struct JavaModelRenderer: JavaFileRenderer { | |||
|
|
|||
| func renderBuilderSetters(modifiers: JavaModifier = [.public]) -> [JavaIR.Method] { | |||
| let setters = transitiveProperties.map { param, schemaObj in | |||
| JavaIR.method(modifiers, "Builder set\(Languages.java.snakeCaseToCamelCase(param))(\(self.typeFromSchema(param, schemaObj)) value)") { [ | |||
| JavaIR.method(modifiers, "Builder set\(Languages.java.snakeCaseToCapitalizedPropertyName(param))(\(self.typeFromSchema(param, schemaObj)) value)") { [ | |||
There was a problem hiding this comment.
This is the only actual real code change in this PR.
techeretic
approved these changes
May 22, 2019
rahul-malik
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setter method name was not correctly generated in the TypeAdapter.
Added a field to board.json example to surface the issue, and ensure tests catch it.