Support nested object type definitions #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously discovered nested object definitions but didn't generate code for them. This change implements that final bit of support. The main missing piece was a recursive operation to return all of the object roots defined within a schema. We were previously only looking at the schema's top-level object root during the file generation step. With this in place, the file generation loop now also operates over *all* object roots defined by a schema.
rahul-malik
reviewed
Jan 3, 2020
rahul-malik
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously discovered nested object definitions but didn't generate
code for them. This change implements that final bit of support.
The main missing piece was a recursive operation to return all of the
object roots defined within a schema. We were previously only looking at
the schema's top-level object root during the file generation step.
With this in place, the file generation loop now also operates over
all object roots defined by a schema.
Resolves #254