Support for no_recursive and only_runtime flags. Fix print_deps #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-malik
suggested changes
Mar 22, 2017
| case help = "help" | ||
|
|
||
| func needsArgument() -> Bool { | ||
| switch self { | ||
| case .outputDirectory: return true | ||
| case .objectiveCClassPrefix: return true | ||
| case .printDeps: return false | ||
| case .noRecursive: return false | ||
| case .onlyRuntime: return false |
There was a problem hiding this comment.
can you run --only_runtime by itself without any schemas specified?
Sources/plank/Cli.swift
Outdated
| var d = dict | ||
| if let v = tuple.1 { | ||
| d[tuple.0] = v | ||
| } |
Sources/plank/Cli.swift
Outdated
| @@ -35,6 +39,8 @@ extension FlagOptions : HelpCommandOutput { | |||
| " --\(FlagOptions.objectiveCClassPrefix.rawValue) - The prefix to add to all generated class names.", | |||
| " --\(FlagOptions.outputDirectory.rawValue) - The directory where generated code will be written.", | |||
| " --\(FlagOptions.printDeps.rawValue) - Just print the path to the dependent schemas necessary to generate the schemas provided and exit.", | |||
| " --\(FlagOptions.noRecursive.rawValue) - Don't generate files recursively. Only generate the one file I ask for.", | |||
| " --\(FlagOptions.onlyRuntime.rawValue) - Only the plank generate runtime files and exit.", | |||
There was a problem hiding this comment.
nit: ordering of words is a bit off here. Should be "Only generate runtime files and exit."
rahul-malik
approved these changes
Mar 22, 2017
bkase
changed the title
rahul-malik
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no_recursiveonly makes the schemas passed inand
--only_runtimejust makes the PlankRuntime filesand
--print_depsoutputs with:s separating the paths of each dependency (like the $PATH variable)These are needed for better incremental builds with Bazel