Nullability support in Plank #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
|
@rahul-malik Here is a diff for adding nullability support to JS / Flow as well as fixes the lint error. That's a diff to fix the error that should work in Swift 3 and 4: After applying both, CI should pass. |
- Add nullability information into Schema IR - Render 'nonnull' or 'nullable' if a property is present in 'required' property. - Update Cocoa / FlowJS examples to incorporate nullability cases - Improve unit test coverage in ObjCIR.swift - Add documentation for nullability support
rahul-malik
force-pushed
the
rmalik-nullability
branch
from
dc0e64c
to
49e57cd
Compare
|
@maicki - Please take a look when you get a chance, I've merged your patches and ensured the build compiles and tests pass locally. |
Generated by 🚫 Danger |
maicki
approved these changes
Aug 16, 2017
| case nonnull | ||
| } | ||
|
|
||
| // Ask @bkase about whether this makes more sense to wrap schemas to express nullability |
| @@ -242,14 +255,18 @@ extension Schema { | |||
| })) | |||
| } | |||
| case JSONType.object: | |||
| let requiredProps = Set(propertyInfo["required"] as? [String] ?? []) | |||
There was a problem hiding this comment.
Not for this PR, but as an idea for all of this stringly accessed property infos should we create an enum for that includes the available property info keys?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
property.