Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make clean warning #65

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Fix make clean warning #65

merged 1 commit into from
Sep 24, 2017

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Jul 25, 2017

Fixes:

$ make clean
xcrun swift build --clean
warning: swift build --clean is deprecated. Use 'swift package clean' instead. (SR-2082)

@ghost
Copy link

ghost commented Jul 25, 2017

🚫 CI failed with log

@maicki
Copy link
Contributor Author

maicki commented Jul 25, 2017

@rahul-malik We may finally should update the swift version on our CI ...

@rahul-malik
Copy link
Collaborator

@maicki it might be time to build with bazel :)

@rahul-malik
Copy link
Collaborator

CI updated so we can merge this now

@rahul-malik rahul-malik merged commit 3fc1bea into pinterest:master Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul-malik rahul-malik rahul-malik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maicki @rahul-malik