Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel build support for Plank #75

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Bazel build support for Plank #75

merged 1 commit into from
Aug 17, 2017

Conversation

rahul-malik
Copy link
Collaborator

  • We're using the rules_apple repository for swift support
  • WORKSPACE defines external dependencies
  • BUILD defines the specific targets (similar to Swift PM)

@rahul-malik rahul-malik requested a review from bkase August 17, 2017 06:48
@rahul-malik
Copy link
Collaborator Author

To verify, we can build with this command

bazel build //:plank --xcode_toolchain=com.apple.dt.toolchain.Swift_3_1 \
    --apple_crosstool_transition \
    --experimental_objc_crosstool=all

bkase
bkase approved these changes Aug 17, 2017
View reviewed changes
Copy link
Contributor

@bkase bkase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is literally easier than xcode

maicki
maicki approved these changes Aug 17, 2017
View reviewed changes
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rahul-malik
Bazel build support for Plank
df1860b 
- We're using the rules_apple repository for swift support
- WORKSPACE defines external dependencies
- BUILD defines the specific targets (similar to Swift PM)
@ghost
Copy link

ghost commented Aug 17, 2017

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

@rahul-malik rahul-malik merged commit 92c9a3f into master Aug 17, 2017
@rahul-malik rahul-malik deleted the rmalik-bazel branch August 18, 2017 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@bkase bkase bkase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahul-malik @maicki @bkase