Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dictionaryRepresentation method so it doesn't conflict with Foundation's one #94

Merged

Conversation

rmls
Copy link
Contributor

@rmls rmls commented Nov 6, 2017

Foundation has a dictionaryRepresentation method already, so Plank's is conflicting with that one. This PR renames it to dictionaryObjectRepresentation to address #90.

@ghost
Copy link

ghost commented Nov 6, 2017

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

@rahul-malik rahul-malik merged commit 91d26a0 into pinterest:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants