Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client fails for command: stats cachedump <slab> <itemcount> #103

Closed
rthille opened this issue Jul 19, 2016 · 3 comments
Closed

Client fails for command: stats cachedump <slab> <itemcount> #103

rthille opened this issue Jul 19, 2016 · 3 comments
Labels
bug

Comments

@rthille
Copy link

rthille commented Jul 19, 2016

This line: https://github.com/pinterest/pymemcache/blob/master/pymemcache/client/base.py#L664
causes the 'stats cachedump 0 0' to turn into 'stats cachedump 0' or worse 'stats 0 cachedump' depending on the dict ordering.
Further, if you hack around that, the client doesn't know how to deal with the lines returned which start with 'ITEM '
@nichochar
Copy link
Collaborator

nichochar commented Jul 22, 2016 •
edited
Loading

Switching out the keys dict for a collections.OrderedDict to make sure the keys are called in order should fix this.
Thanks for reporting @rthille . Would you like to make a PR fix?

@rthille
Copy link
Author

rthille commented Aug 2, 2016

I don't think just moving to an ordered dict will work because for the 'stats cachedump' call you can have two args which are identical.

@jogo jogo added the bug label Mar 16, 2017
@jogo
Copy link
Contributor

jogo commented Mar 16, 2017

Confirmed this is still a reproducible issue.

jogo added a commit to jogo/pymemcache that referenced this issue Mar 24, 2017
@jogo
Add support for stats cachedump
bf74507 
Stats cachedump has a different input and output format compared to
most stats commands. Previously this would fail with a cryptic error.

Fixes issue pinterest#103
@jogo jogo mentioned this issue Mar 24, 2017
Merged
jogo added a commit to jogo/pymemcache that referenced this issue Mar 25, 2017
@jogo
Add support for stats cachedump
777ad88 
Stats cachedump has a different input and output format compared to
most stats commands. Previously this would fail with a cryptic error.

Fixes issue pinterest#103
jogo added a commit to jogo/pymemcache that referenced this issue Mar 29, 2017
@jogo
Add support for stats cachedump
7351bdb 
Stats cachedump has a different input and output format compared to
most stats commands. Previously this would fail with a cryptic error.

Fixes issue pinterest#103
@jogo jogo closed this as completed Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jogo @nichochar @rthille