Improve _check_key() and _store_cmd() performance #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making the batching changes in #182 I noticed a few performance hot-spots.
_check_key()
is called at least once on every single operation and was doing a lot of repeat or just inefficient work._store_cmd()
was calculating and encodingextra
andexpire
for every key/value pair even though they don't change (I didn't move this in the previous PR because I didn't want to muddy my intentions).The first change is responsible for most of the performance increase, it affects every method, and the difference scales with key length. The second only impacts
set_many()
but in my 100-key tests was responsible for a decent 7.5% gain.Benchmarks from master with irrelevant lines trimmed:
With this diff: