Created sampler() method within NestedController #1313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created new getter - used getter in notebooks and test files
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 87 87
Lines 8932 8934 +2
=========================================
+ Hits 8932 8934 +2
Continue to review full report at Codecov.
|
rccreswell
reviewed
Mar 4, 2021
| @@ -667,6 +667,10 @@ def run(self): | |||
|
|
|||
| return self._m_posterior_samples | |||
|
|
|||
| def sampler(self): | |||
| """ Returns sampler used by the controller. """ | |||
There was a problem hiding this comment.
What do you think of including this specific comment, which is similar to the sampler() docstring on MCMC controller?
Suggested change
| """ Returns sampler used by the controller. """ | |
| """Returns the underlying :class:`NestedSampler` object.""" |
There was a problem hiding this comment.
Good point. I'll incorporate this into my new PR about multinest.
|
Closing as out of date due to #1034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1312