Tests are failing? #1511
Merged
Tests are failing? #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1511 +/- ##
===========================================
+ Coverage 96.49% 100.00% +3.50%
===========================================
Files 114 97 -17
Lines 9925 9577 -348
===========================================
Hits 9577 9577
+ Misses 348 0 -348 ☔ View full report in Codecov by Sentry. |
|
Actually everything's fine. Codecov was reporting #1294 as "main" for some reason: https://app.codecov.io/gh/pints-team/pints/tree/main/pints |
|
Can somebody approve this PR so I can merge it in and make codecov report that all is well again? |
I-Bouros
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems tests are failing somehow, so creating PR to check it out