add sensitivities for fitzhugh nagumo model #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 82.29% 82.82% +0.52%
==========================================
Files 36 36
Lines 2864 2940 +76
==========================================
+ Hits 2357 2435 +78
+ Misses 507 505 -2
Continue to review full report at Codecov.
|
I have corrected the derivative. it now passes unit test in tensorflow.
Updated FN with correct derivatives
|
@sanmitraghosh your tests are failing! |
MichaelClerx
approved these changes
Apr 1, 2018
pints/toy/_fitzhugh_nagumo_model.py
Outdated
| def simulate_with_sensitivities(self, parameters, times): | ||
| return self._simulate(parameters, times, True) | ||
|
|
||
| def _simulate(self, parameters, times, sensitivities): | ||
| """ See :meth:`pints.ForwardModel.simulate()`. """ |
There was a problem hiding this comment.
This docstring is no longer appropriate! Should have a full one here with:
Arguments:
`parameters`
Lalala
etc. that explains the extra sensitivities switch
46 tasks
MichaelClerx
pushed a commit
that referenced
this pull request
Feb 22, 2019
add sensitivities for fitzhugh nagumo model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to previous logistic sensitivities, but for an ode model