Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E tests with OpenSSL #11

Closed
Sean-Der opened this issue Nov 20, 2018 · 5 comments
Closed

Add E2E tests with OpenSSL #11

Sean-Der opened this issue Nov 20, 2018 · 5 comments

Comments

@Sean-Der
Copy link
Member

Sean-Der commented Nov 20, 2018

Add some basic testing using s_client + s_server

The author should also refactor/re-use our existing E2E testing code so that we don't duplicate in both places.

@Sean-Der
Copy link
Member Author

Sean-Der commented Dec 3, 2018

Also introduce packet loss on either side. Create a Client/Server from a wrapped Conn and add a certain % of packet loss (it may be helpful to log messages, otherwise fixing will be really hard here)

@backkem
Copy link
Member

backkem commented Dec 3, 2018

We should probably implement these types of tests globally so we can throw them at any layer of the stack. The beginnings of this are here. Eventually it could look like this.

Sean-Der added a commit that referenced this issue Dec 10, 2018
The tests themselves aren't available yet but this came from starting
OpenSSL tests

Relates to #11
@Sean-Der Sean-Der changed the title Implement integration testing Implement E2E testing Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 11, 2018
@Sean-Der Sean-Der changed the title Implement E2E testing Add E2E tests with OpenSSL Dec 11, 2018
Sean-Der added a commit that referenced this issue Dec 12, 2018
@Sean-Der Sean-Der added good first issue Good for newcomers triaged Has been reviewed and removed backlog labels Jul 1, 2019
@daenney daenney mentioned this issue Nov 12, 2019
4 tasks
@igolaizola
Copy link
Member

OpenSSL tests have been added in #193

TODO:

  • Make OpenSSL work with ed25519 test

@at-wat
Copy link
Member

at-wat commented Mar 11, 2020

I found that our implementation of Ed25519 signature calculation and hash used in ServerKeyExchange/CertificateVerify messages are wrong. Since both of our server and client have same bug, they can communicate each other.
I have made a fix for it, and now I'm cleaning the code.

One bad news is that OpenSSL haven't support DTLS Ed25519 yet.
I could confirm my fix works with this openssl branch: openssl/openssl#11115

@at-wat
Copy link
Member

at-wat commented Mar 12, 2020

Ed25519 implementation of the master branch should be fixed now. We can enable the E2E test once OpenSSL supports DTLS 1.2 Ed25519.

@daenney daenney removed good first issue Good for newcomers triaged Has been reviewed labels Mar 12, 2020
@daenney daenney added the waiting:upstream Waiting on a fix in an upstream project/depedency label Mar 12, 2020
daenney added a commit that referenced this issue May 17, 2022
OpenSSL finally caught up.

Closes: #11
daenney added a commit that referenced this issue May 17, 2022
OpenSSL finally caught up.

Closes: #11
daenney added a commit that referenced this issue May 17, 2022
OpenSSL finally caught up.

Closes: #11
daenney added a commit that referenced this issue May 17, 2022
OpenSSL finally caught up.

Closes: #11
daenney added a commit that referenced this issue May 17, 2022
OpenSSL finally caught up.

Closes: #11
@daenney daenney removed the waiting:upstream Waiting on a fix in an upstream project/depedency label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants