refactor: rename test_utils to utils_test to remove stretchr/testify dep #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Do we have this problem anywhere else? I will add this check to CI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
==========================================
- Coverage 79.25% 79.15% -0.10%
==========================================
Files 42 41 -1
Lines 3789 3738 -51
==========================================
- Hits 3003 2959 -44
+ Misses 551 547 -4
+ Partials 235 232 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
After applying this PR I don't see any other reference to testify in my project's build which also imports the main webrtc packages. So, I think this is probably the only case where that happened. |
I noticed that the pion-ice package had ~1MB of extra binary size due to the dependency on stretchr/testify. Renaming test_utils.go to utils_test.go removes stretchr/testify from any non-test build and fixes this dependency. The tests still pass and the package still builds the same. One can check the dependency graph with goda: https://github.com/loov/goda goda graph "reach(.:all, github.com/stretchr/testify/require)" |\ dot -Tsvg -o graph.svg Signed-off-by: Christian Stewart <christian@aperture.us>
Sean-Der
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the pion-ice package had ~1MB of extra binary size due to the dependency on stretchr/testify.
Renaming test_utils.go to utils_test.go removes stretchr/testify from any non-test build and fixes this dependency. The tests still pass & the package still builds the same.
One can check the dependency graph with goda:
https://github.com/loov/goda
goda graph "reach(.:all, github.com/stretchr/testify/require)" | dot -Tsvg -o graph.svg